update the readme: update contributing giude

This commit is contained in:
Mahmoud Zalt 2016-08-16 15:47:42 +03:00
parent 1614f0fb2d
commit e8562272b0
1 changed files with 15 additions and 3 deletions

View File

@ -54,9 +54,21 @@ Help us to maximize the effort we can spend fixing issues and adding new
features, by not reporting duplicate issues.
### Before Submitting a Pull Request (PR)
### Submitting a Pull Request (PR)
Before you submit your pull request consider the following guidelines:
Always Test everything and make sure its working:
- Pull the latest updates (or fork of you dont have permission)
- Before editing anything:
- Test building the container (docker-compose build --no-cache container-name) build with no cache first.
- Test running the container with some other containers in real app and see of everything is working fine.
- Now edit the container (edit section by section and test rebuilding the container after every edited section)
- Testing building the container (docker-compose build container-name) with no errors.
- Test it in real App.
### Submitting a PR
Consider the following guidelines:
* Search [GitHub](https://github.com/LaraDock/laradock/pulls) for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort.
@ -93,7 +105,7 @@ git push origin my-fix-branch -f
### After your pull request is merged
### After your PR is merged
After your pull request is merged, you can safely delete your branch and pull the changes
from the main (upstream) repository: