From e8562272b03b477a436a9023f381a969886c7dbb Mon Sep 17 00:00:00 2001 From: Mahmoud Zalt Date: Tue, 16 Aug 2016 15:47:42 +0300 Subject: [PATCH] update the readme: update contributing giude --- CONTRIBUTING.md | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9e1cedb..3fd3b67 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -54,9 +54,21 @@ Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. +### Before Submitting a Pull Request (PR) -### Submitting a Pull Request (PR) -Before you submit your pull request consider the following guidelines: +Always Test everything and make sure its working: + +- Pull the latest updates (or fork of you don’t have permission) +- Before editing anything: + - Test building the container (docker-compose build --no-cache container-name) build with no cache first. + - Test running the container with some other containers in real app and see of everything is working fine. +- Now edit the container (edit section by section and test rebuilding the container after every edited section) + - Testing building the container (docker-compose build container-name) with no errors. + - Test it in real App. + + +### Submitting a PR +Consider the following guidelines: * Search [GitHub](https://github.com/LaraDock/laradock/pulls) for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort. @@ -93,7 +105,7 @@ git push origin my-fix-branch -f -### After your pull request is merged +### After your PR is merged After your pull request is merged, you can safely delete your branch and pull the changes from the main (upstream) repository: