From c31e002064c935b5184e27adc66ebb03ad77b53c Mon Sep 17 00:00:00 2001 From: Tristan Bailey Date: Thu, 4 May 2017 08:22:32 +0100 Subject: [PATCH] Update Redis Docker File The dir for the conf seems to be missing from the base image, so the copy fails Also if the server does not start with the conf as parameter it will not pick it up. Which leaves Redis wide open to attack by default: Example try to telnet to your ip on the redis port for this container: telnet 192.168.1.11 6379 echo "Hey no AUTH required!" --- redis/Dockerfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/redis/Dockerfile b/redis/Dockerfile index e8fedab..35df84d 100644 --- a/redis/Dockerfile +++ b/redis/Dockerfile @@ -2,10 +2,13 @@ FROM redis:latest MAINTAINER Mahmoud Zalt +## For security settings uncomment, make the dir, copy conf, and also start with the conf, to use it +#RUN mkdir -p /usr/local/etc/redis #COPY redis.conf /usr/local/etc/redis/redis.conf VOLUME /data EXPOSE 6379 +#CMD ["redis-server", "/usr/local/etc/redis/redis.conf"] CMD ["redis-server"]